Skip to content

TEZ-4706: Use project build directory for Graphviz output and update documentation#480

Open
Aggarwal-Raghav wants to merge 1 commit intoapache:masterfrom
Aggarwal-Raghav:TEZ-4706
Open

TEZ-4706: Use project build directory for Graphviz output and update documentation#480
Aggarwal-Raghav wants to merge 1 commit intoapache:masterfrom
Aggarwal-Raghav:TEZ-4706

Conversation

@Aggarwal-Raghav
Copy link
Copy Markdown
Contributor

@Aggarwal-Raghav Aggarwal-Raghav commented Apr 14, 2026

Presently, Tez.gv (tez-dag/pom.xml) is created in project root directory. As the Visualize profile is specific to tez-dag, its better to move the Tez.gv in tez-dag/target/ directory.

@Aggarwal-Raghav
Copy link
Copy Markdown
Contributor Author

Aggarwal-Raghav commented Apr 14, 2026

@abstractdog , i think its better to move to
<tez.graphviz.output.file>Tez.gv</tez.graphviz.output.file> => <tez.graphviz.output.file>${project.build.directory}/Tez.gv</tez.graphviz.output.file>

it will generate in tez-dag/target/Tez.gv ?

@tez-yetus
Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 14s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 codespell 0m 7s No new issues.
+1 💚 blanks 0m 0s The patch has no blanks issues.
_ Other Tests _
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
1m 15s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-480/1/artifact/out/Dockerfile
GITHUB PR #480
Optional Tests dupname asflicense codespell detsecrets
uname Linux dff5152267bd 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-480/src/.yetus/personality.sh
git revision master / 53f9a6a
Max. process+thread count 56 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-480/1/console
versions git=2.43.0 maven=3.9.14 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Copy Markdown
Contributor

@abstractdog , i think its better to move to <tez.graphviz.output.file>Tez.gv</tez.graphviz.output.file> => <tez.graphviz.output.file>${project.build.directory}/Tez.gv</tez.graphviz.output.file>

it will generate in tez-dag/target/Tez.gv ?

even better, thanks! feel free to rename ticket/PR accordingly

also, don't forget to add this detail in the other ongoing PR:

* `-Dtez.graphviz.output.file` (Default: Tez.gv)

#477
because the default will become target/Tez.gv in this case

@Aggarwal-Raghav
Copy link
Copy Markdown
Contributor Author

can you please review #477 then post that I'll update this, I don't wanna update BUILDING.txt in this PR or it will be like half-work in this pr (pom changes) and other half changes in 477 (REAME.md) changes.

@Aggarwal-Raghav Aggarwal-Raghav changed the title TEZ-4706: Consider adding Tez.gv or *.gv to gitignore TEZ-4706: Use project build directory for Graphviz output and update documentation Apr 14, 2026
@tez-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 47s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for branch
+1 💚 mvninstall 4m 19s master passed
+1 💚 compile 2m 34s master passed
+1 💚 javadoc 2m 0s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 4m 1s the patch passed
+1 💚 codespell 1m 36s No new issues.
+1 💚 compile 2m 32s the patch passed
+1 💚 javac 2m 32s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 markdownlint 0m 2s No new issues.
+1 💚 javadoc 1m 57s the patch passed
_ Other Tests _
+1 💚 unit 5m 37s tez-dag in the patch passed.
+1 💚 unit 70m 57s root in the patch passed.
+1 💚 asflicense 1m 24s The patch does not generate ASF License warnings.
107m 2s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-480/2/artifact/out/Dockerfile
GITHUB PR #480
Optional Tests dupname asflicense codespell detsecrets markdownlint javac javadoc unit xmllint compile
uname Linux 837daa0f75e2 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-480/src/.yetus/personality.sh
git revision master / b1d9b94
Default Java Ubuntu-21.0.10+7-Ubuntu-124.04
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-480/2/testReport/
Max. process+thread count 1354 (vs. ulimit of 5500)
modules C: tez-dag . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-480/2/console
versions git=2.43.0 maven=3.9.14 codespell=2.4.1 markdownlint=0.46.0
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants