TIKA-2340 cleanup of direct dependencies / fix locale-dependent test case#171
Closed
user667 wants to merge 2 commits intoapache:masterfrom
user667:QA-Cleanup-of-direct-dependencies
Closed
TIKA-2340 cleanup of direct dependencies / fix locale-dependent test case#171user667 wants to merge 2 commits intoapache:masterfrom user667:QA-Cleanup-of-direct-dependencies
user667 wants to merge 2 commits intoapache:masterfrom
user667:QA-Cleanup-of-direct-dependencies
Conversation
Member
Add direct dependencies to * 'org.apache.httpcomponents:httpcore/httpclient' in favor of 'edu.ucar:httpservices'. Both libraries were not exclusively used by netcdf parsers and therefore should be provided by a direct dependency instead of relying on transitive deps. * 'com.google.guava:guava' * 'commons-lang:commons-lang' 'org.apache.tika.parser.wordperfect.WPInputStream' requires string-utils otherwise scope could be set to 'test'. * 'javax.ws.rs:javax.ws.rs-api'
user667
changed the title
Author
|
BTW: This is just a small percentage of what should be added as direct dependencies. Unfortunately I don't know most of the parsers and the libraries they use and therefore cannot provide the rest of the list (see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an effort of dependency cleanup (with the help of mvn dependency:analyze and others). Not sure if this is acceptable without TIKA ticket number (or as such), I'll be glad to adjust this PR.
We've been updating to a recent (1.6-1.14) tika version lately and found a delta of +40libs/+20MB and went on to investigate. Turns out tika-parsers relies on a lot of transitive dependencies.
These commits try to specify (some) direct dependencies for libraries that are used in imports of parser classes. Additionally one of the test cases failed on my local setup with a non-default-English locale.