fix for TIKA-2385 contributed by pmweiss5#183
Merged
dameikle merged 1 commit intoapache:masterfrom Dec 1, 2017
Merged
Conversation
dameikle
changed the title
Member
|
Thank for the patch. Unfortunately the test doesn't work for me |
Member
|
Sorry, I didn't mean to close this, not enough morning coffee :) Thanks for the PR. Was looking to include this into the code base but the test image requires the default ImageMagick security limits (on Ubuntu at least) to be lifted. @pmweiss - do you have a smaller test image that would meet the limits? If not, I can create one. |
Member
|
I've added a smaller image and adapted the Python check to check for the dependencies as well to ensure the test can run on machines that have Python but not all of the dependencies. Thanks again @pmweiss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.