Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tika-app/src/test/resources/configs/config-template.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"queueSize": 10000,
"numEmitters": 1,
"emitIntermediateResults": false,
"maxForEmitBatchBytes": 100000,
"directEmitThresholdBytes": 100000,
"timeoutMillis": 60000,
"startupTimeoutMillis": 240000,
"sleepOnStartupTimeoutMillis": 240000,
Expand All @@ -53,7 +53,6 @@
"staleFetcherTimeoutSeconds": 600,
"staleFetcherDelaySeconds": 60,
"forkedJvmArgs": ["-Xmx1g", "-XX:+UseG1GC"],
"tikaConfig": "TIKA_CONFIG",
"javaPath": "java"
},
"plugin-roots": "PLUGIN_ROOTS"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ private void fetchAndParseImpl(FetchAndParseRequest request,
FetchAndParseReply.newBuilder()
.setFetchKey(request.getFetchKey())
.setStatus(pipesResult.status().name());
if (pipesResult.status().equals(PipesResult.STATUS.FETCH_EXCEPTION)) {
if (pipesResult.status().equals(PipesResult.RESULT_STATUS.FETCH_EXCEPTION)) {
fetchReplyBuilder.setErrorMessage(pipesResult.message());
}
if (pipesResult.emitData() != null && pipesResult.emitData().getMetadataList() != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ public void testBiStream(Resources resources) throws Exception {
@Override
public void onNext(FetchAndParseReply fetchAndParseReply) {
LOG.debug("Fetched {} with metadata {}", fetchAndParseReply.getFetchKey(), fetchAndParseReply.getFieldsMap());
if (PipesResult.STATUS.FETCH_EXCEPTION.name().equals(fetchAndParseReply.getStatus())) {
if (PipesResult.RESULT_STATUS.FETCH_EXCEPTION.name().equals(fetchAndParseReply.getStatus())) {
errors.add(fetchAndParseReply);
} else {
successes.add(fetchAndParseReply);
Expand Down
2 changes: 1 addition & 1 deletion tika-grpc/src/test/resources/tika-pipes-test-config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<arg>-XX:ParallelGCThreads=2</arg>
</forkedJvmArgs>
<timeoutMillis>60000</timeoutMillis>
<maxForEmitBatchBytes>-1</maxForEmitBatchBytes> <!-- disable emit -->
<directEmitThresholdBytes>-1</directEmitThresholdBytes> <!-- disable emit -->
</params>
</pipes>
<fetchers>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,11 @@
}
},
"pipes": {
"maxForEmitBatchBytes": 10000,
"directEmitThresholdBytes": 10000,
"emitMaxEstimatedBytes": 100000,
"emitWithinMillis": 10,
"numEmitters": 1,
"numClients": 1,
"tikaConfig": "TIKA_CONFIG",
"forkedJvmArgs": [
"-Xmx1g",
"-XX:ParallelGCThreads=2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
</metadataFilters>
<async>
<params>
<maxForEmitBatchBytes>10000</maxForEmitBatchBytes>
<directEmitThresholdBytes>10000</directEmitThresholdBytes>
<emitMaxEstimatedBytes>100000</emitMaxEstimatedBytes>
<emitWithinMillis>10</emitWithinMillis>
<numEmitters>1</numEmitters>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,11 @@
}
},
"pipes": {
"maxForEmitBatchBytes": 10000,
"directEmitThresholdBytes": 10000,
"emitMaxEstimatedBytes": 100000,
"emitWithinMillis": 60000,
"numEmitters": 1,
"numClients": 3,
"tikaConfig": "TIKA_CONFIG",
"forkedJvmArgs": [
"-Xmx512m",
"-XX:ParallelGCThreads=2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,11 @@
}
},
"pipes": {
"maxForEmitBatchBytes": 10000,
"directEmitThresholdBytes": 10000,
"emitMaxEstimatedBytes": 100000,
"emitWithinMillis": 60000,
"numEmitters": 1,
"numClients": 3,
"tikaConfig": "TIKA_CONFIG",
"pipesPluginsConfig": "PLUGINS_CONFIG",
"forkedJvmArgs": [
"-Xmx512m",
"-XX:ParallelGCThreads=2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,11 @@
}
},
"pipes": {
"maxForEmitBatchBytes": 10000,
"directEmitThresholdBytes": 10000,
"emitMaxEstimatedBytes": 100000,
"emitWithinMillis": 10,
"numEmitters": 1,
"numClients": 1,
"tikaConfig": "{TIKA_CONFIG}",
"forkedJvmArgs": [
"-Xmx1g",
"-XX:ParallelGCThreads=2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
</metadataFilter>
</metadataFilters>
<async>
<maxForEmitBatchBytes>10000</maxForEmitBatchBytes>
<directEmitThresholdBytes>10000</directEmitThresholdBytes>
<emitMaxEstimatedBytes>100000</emitMaxEstimatedBytes>
<emitWithinMillis>10</emitWithinMillis>
<numEmitters>1</numEmitters>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,11 @@
}
},
"pipes": {
"maxForEmitBatchBytes": 10000,
"directEmitThresholdBytes": 10000,
"emitMaxEstimatedBytes": 100000,
"emitWithinMillis": 10,
"numEmitters": 1,
"numClients": 1,
"tikaConfig": "TIKA_CONFIG",
"forkedJvmArgs": [
"-Xmx1g",
"-XX:ParallelGCThreads=2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,11 @@
}
],
"pipes": {
"maxForEmitBatchBytes": 10000,
"directEmitThresholdBytes": 10000,
"emitMaxEstimatedBytes": 100000,
"emitWithinMillis": 10,
"numEmitters": 1,
"numClients": 1,
"tikaConfig": "{TIKA_CONFIG}",
"forkedJvmArgs": [
"-Xmx1g",
"-XX:ParallelGCThreads=2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
</metadataFilter>
</metadataFilters>
<async>
<maxForEmitBatchBytes>10000</maxForEmitBatchBytes>
<directEmitThresholdBytes>10000</directEmitThresholdBytes>
<emitMaxEstimatedBytes>100000</emitMaxEstimatedBytes>
<emitWithinMillis>10</emitWithinMillis>
<numEmitters>1</numEmitters>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ void write(Path output) throws IOException {
PipesConfig pipesConfig = new PipesConfig();

pipesConfig.setNumClients(simpleAsyncConfig.getNumClients() == null ? 2 : simpleAsyncConfig.getNumClients());
pipesConfig.setTikaConfig(output.toAbsolutePath().toString());

if (simpleAsyncConfig.getXmx() != null) {
pipesConfig.setForkedJvmArgs(new ArrayList<>(List.of(simpleAsyncConfig.getXmx())));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public void testBasic(@TempDir Path dir) throws Exception {
Path tmp = Files.createTempFile(dir, "plugins-",".json");
pluginsWriter.write(tmp);
TikaJsonConfig tikaJsonConfig = TikaJsonConfig.load(tmp);
PipesConfig pipesConfig = PipesConfig.load(tikaJsonConfig);
PipesConfig pipesConfig = PipesConfig.load(tikaJsonConfig, tmp);
assertEquals("-Xmx1g", pipesConfig.getForkedJvmArgs().get(0));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"queueSize": 10000,
"numEmitters": 1,
"emitIntermediateResults": false,
"maxForEmitBatchBytes": 100000,
"directEmitThresholdBytes": 100000,
"timeoutMillis": 60000,
"startupTimeoutMillis": 240000,
"sleepOnStartupTimeoutMillis": 240000,
Expand All @@ -37,7 +37,6 @@
"staleFetcherTimeoutSeconds": 600,
"staleFetcherDelaySeconds": 60,
"forkedJvmArgs": ["-Xmx1g", "-XX:+UseG1GC"],
"tikaConfig": "TIKA_CONFIG",
"javaPath": "java"
},
"plugin-roots": "PLUGIN_ROOTS"
Expand Down
Loading
Loading