Skip to content

TIKA-2599: Fixed closing of styles around Hyperlinks. Contributed by Ronan O'Sullivan. #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dameikle merged 1 commit into from
Oct 29, 2018
Merged

TIKA-2599: Fixed closing of styles around Hyperlinks. Contributed by Ronan O'Sullivan. #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tika-parsers/src/main/java/org/apache/tika/parser/microsoft/WordExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,8 @@ private int handleSpecialCharacterRuns(Paragraph p, int index, boolean skipStyli
url = text.substring(start, end);
}

xhtml.startElement("a", "href", url);
closeStyleElements(skipStyling, xhtml);
xhtml.startElement("a", "href", url);
for (CharacterRun cr : texts) {
handleCharacterRun(cr, skipStyling, xhtml);
}
Expand Down
9 changes: 9 additions & 0 deletions tika-parsers/src/test/java/org/apache/tika/parser/microsoft/WordParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,15 @@ public void testBoldHyperlink() throws Exception {
assertContains("<a href=\"http://tika.apache.org/\"><b><u>hyper</u></b><u> link</u></a>; bold" , xml);
}

@Test
public void testHyperlinkSurroundedByItalics() throws Exception {
//TIKA-2599
String xml = getXML("testWORD_italicsSurroundingHyperlink.doc").xml;
xml = xml.replaceAll("\\s+", " ");
assertContains("<body><p><i>Italic Test before link </i><a href=\"http://www.google.com\"><b><i>" +
"<u>hyperlink italics</u></i></b></a><i> Italic text after hyperlink</i></p>", xml);
}

@Test
public void testMacros() throws Exception {

Expand Down
Binary file added tika-parsers/src/test/resources/test-documents/testWord_italicsSurroundingHyperlink.doc
View file
Open in desktop
Binary file not shown.