TIKA-2783: Add unit tests for org.apache.tika.mime.HexCoDec#259
Closed
JohnLBergqvist wants to merge 1 commit intoapache:masterfrom
Diffblue-benchmarks:TIKA-2783
Closed
TIKA-2783: Add unit tests for org.apache.tika.mime.HexCoDec#259JohnLBergqvist wants to merge 1 commit intoapache:masterfrom Diffblue-benchmarks:TIKA-2783
JohnLBergqvist wants to merge 1 commit intoapache:masterfrom
Diffblue-benchmarks:TIKA-2783
Conversation
These tests were written by Diffblue Cover.
kkrugler
approved these changes
Nov 14, 2018
Contributor
kkrugler
left a comment
kkrugler
left a comment
There was a problem hiding this comment.
lgtm. A test for thrown exception with odd input array length would be nice, but not required.
Author
|
@kkrugler Many thanks. The first test in the file has a |
JohnLBergqvist
changed the title
JohnLBergqvist
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I ran JaCoCo over the
tika-coremodule, and found that theorg.apache.tika.mime.HexCoDecclass was missing unit test coverage.I've written some tests for this class, with the help of Diffblue Cover. The majority of the class is now covered as a result of these tests.
Hopefully these tests should help you detect regressions caused by future code changes.