Skip to content

TIKA-4699 - fix bundle to handle tika-standard-parsers-package#2752

Merged
tballison merged 1 commit into
mainfrom
TIKA-4699
Apr 9, 2026
Merged

TIKA-4699 - fix bundle to handle tika-standard-parsers-package#2752
tballison merged 1 commit into
mainfrom
TIKA-4699

Conversation

@tballison
Copy link
Copy Markdown
Contributor

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika is successfully built and unit tests pass by running ./mvnw clean test
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

@tballison
Copy link
Copy Markdown
Contributor Author

@kwin wdyt?

@@ -143,6 +143,10 @@
org.apache.tika.parser.internal.Activator
</Bundle-Activator>
<Embed-Dependency>*;scope=compile;artifactId=tika-parsers-standard-package|
Copy link
Copy Markdown
Member

@kwin kwin Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, I haven't tried to deploy in OSGi though yet.

@kwin
Copy link
Copy Markdown
Member

kwin commented Apr 8, 2026

Still unsure what tika-parsers-standard-package is supposed to embed on its own. Who is supposed to use it and for what purpose? I think having an OSGi bundle without the third party dependencies would still be beneficial. Then one can decide between deploying:

  1. tika-bundle-standard (standard-parsers + their third party dependencies)
  2. tika-standards-parsers-package (all standard parsers)

The suffix package seems a bit fuzzy to me. Is this only supposed to be used to ease dependency management at compile time (then this should have pom packaging only) or is this supposed to be usable OSGi bundle/JAR to be used in OSGi containers or the Java Classpath?

@tballison
Copy link
Copy Markdown
Contributor Author

tballison commented Apr 8, 2026

I made the *-package initially to avoid having to import the 25 standard parser modules in tika-app, tika-server and tika-grpc. I did that with only a mechanical copy/paste of osgi components/Activator (I think from 1.x -> 2.x) and no real thought for osgi.

I opened https://issues.apache.org/jira/browse/TIKA-4712 to clarify this... wdyt?

I'm grateful to have someone with an actual osgi use case help get this right ... now. Thank you.

@tballison tballison merged commit dc2ee57 into main Apr 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants