Skip to content

4x-reg-sax-fixes#2773

Merged
tballison merged 6 commits intomainfrom
4x-reg-sax-fixes
Apr 17, 2026
Merged

4x-reg-sax-fixes#2773
tballison merged 6 commits intomainfrom
4x-reg-sax-fixes

Conversation

@tballison
Copy link
Copy Markdown
Contributor

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika is successfully built and unit tests pass by running ./mvnw clean test
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

Copy link
Copy Markdown

@utafrali utafrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall direction is correct: these changes make Tika more resilient against truncated and malformed OOXML/ZIP files by converting hard failures into metadata warnings. The main blocker is a real NPE bug in the OPCPackageDetector fallback path where a missing [Content_Types].xml entry would silently crash rather than be caught by the IOException handler. The other issues (FQCN style, continue after iterator failure, no tests) are smaller but worth addressing before merge.

@tballison tballison merged commit 619077d into main Apr 17, 2026
5 checks passed
@tballison tballison deleted the 4x-reg-sax-fixes branch April 17, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants