Merged
Conversation
…e json response is clean
Contributor
|
I'm good with this (once squashed, which I can do at merge time). I suspect this code was added before we had logging. I wonder if we should use LOG.info() instead, and change the unit test to check for the existence/size of the output file. |
tballison
pushed a commit
that referenced
this pull request
Sep 4, 2019
* need to lowercase the output file to match the format passed to tesseract cmd line * need to lowercase the output file to match the format passed to tesseract cmd line * pull original code from apache/tika * Send informational output to System.err, not System.out so commandline json response is clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a PR that fixes sending information information to System.err, so you can return clean JSON when using tika-app on the commandline.
There are some extract commits that are from merging my tika project, and not sure how to remov them. Maybe just a cherrypick?