TIKA-4723 follow-up: fix sqlite3 shade filter and correct docs#2810
Conversation
…ackages Add module-info.class, META-INF/LICENSE.md, and META-INF/NOTICE.md exclusions to the maven-shade-plugin filter in tika-parser-sqlite3-package. These were present in tika-parser-scientific-package and tika-parser-nlp-package but missing in sqlite3, which could cause duplicate module-info.class entries in the shaded jar on Java 9+. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…se-artifacts.adoc The doc stated that starting tika-grpc with no plugins loaded triggers a TikaConfigException. The actual behaviour (TikaGrpcServerImpl.java line 133) is a LOG.warn with a helpful download URL; the server continues to start. Correct the doc to match the real code path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@tballison i reviewed your changes. found no issues. claude recommended this tiny stuff but i think we can close this pr unless you find value in that stuff |
|
Looks good. Will take a look early tomorrow. Thank you! This doesn't break anything for grpc, right? |
|
we have e2e tests @tballison i'll check to see how they are |
There was a problem hiding this comment.
Pull request overview
Follow-up for TIKA-4723 to keep the sqlite3 parser “shaded jar” behavior aligned with other parser packages and to correct release-guide documentation about tika-grpc behavior when no PF4J plugins are present.
Changes:
- Added missing
maven-shade-pluginfilter exclusions (module-info.class,META-INF/LICENSE.md,META-INF/NOTICE.md) to the sqlite3 shaded package, matching sister packages. - Updated the release artifacts guide to reflect that
tika-grpclogs a warning (rather than throwingTikaConfigException) when started without plugins.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tika-parsers/tika-parsers-extended/tika-parser-sqlite3-package/pom.xml | Aligns shade filter exclusions with other shaded parser-package modules to avoid duplicate entries and reduce metadata clutter. |
| docs/modules/ROOT/pages/maintainers/release-guides/release-artifacts.adoc | Corrects documentation describing tika-grpc startup behavior with an empty plugin set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Summary
Follow-up fixes for TIKA-4723 (merged via #2809).
Changes
1.
tika-parser-sqlite3-package/pom.xml— align shade filter with sister packagesThe
maven-shade-pluginfilter intika-parser-sqlite3-packagewas missing three exclusions present in bothtika-parser-scientific-packageandtika-parser-nlp-package:module-info.class— without this exclusion, shading multiple deps that each carry amodule-info.classcauses a duplicate-entry error in the shaded jar on Java 9+.META-INF/LICENSE.md— duplicate clutter; theApacheLicenseResourceTransformeralready handles the text-formatLICENSE.META-INF/NOTICE.md— same rationale asLICENSE.md.2.
docs/modules/ROOT/pages/maintainers/release-guides/release-artifacts.adoc— fix incorrect TikaConfigException claimThe doc said:
This is factually wrong.
TikaGrpcServerImpl(line 133) logs aLOG.warnwhenpluginManager.getPlugins().isEmpty()— it does not throw aTikaConfigException. The server continues to start; fetcher-dependent RPC calls simply fail at runtime. Corrected the description to match the actual code path.Review Focus Areas
tika-parser-sqlite3-package/pom.xmlshade<filters>block — confirm the three new exclusions are correct and complete.release-artifacts.adocparagraph about empty plugins — confirm the new wording accurately reflects startup behaviour.Critical Files
tika-parsers/tika-parsers-extended/tika-parser-sqlite3-package/pom.xmldocs/modules/ROOT/pages/maintainers/release-guides/release-artifacts.adocTesting Instructions
Review Checklist