Merged
Conversation
Merged
In method getPath, copy data from InputStream to a temporary file should use current TikaInputStream. Otherwise the variable of TikaInputStream `position` will not update. There is not meaning if `position` is not real position.
PeterAlfredLee
force-pushed
the
fixTikaInputStream
branch
from
b989928 to
4e67097
Compare
puthurr
pushed a commit
to puthurr/tika-fork
that referenced
this pull request
Jun 13, 2022
In method getPath, copy data from InputStream to a temporary file should use current TikaInputStream. Otherwise the variable of TikaInputStream `position` will not update. There is not meaning if `position` is not real position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In method
getPath, copy data from InputStream to a temporary file should use current TikaInputStream.Otherwise the variable of TikaInputStream
positionwill not update.There is not meaning if
positionis not real position.