Simplify some equals statement by use Objects.equals#377
Merged
Conversation
kkrugler
reviewed
Nov 7, 2020
| if (relativeSourceFilePath != null ? !relativeSourceFilePath.equals(that.relativeSourceFilePath) : that.relativeSourceFilePath != null) | ||
| return false; | ||
| return extractFile != null ? extractFile.equals(that.extractFile) : that.extractFile == null; | ||
| if (!Objects.equals(relativeSourceFilePath, that.relativeSourceFilePath)) return false; |
Contributor
There was a problem hiding this comment.
In general I think Tika uses a "always braces" style, so this would be better as:
if (!blah) {
return false;
} else {
return Objects.equals(blah);
}
Member
Author
There was a problem hiding this comment.
Sure. And this is also the style I prefer. I made the if clause like this cause I want to have the same style as line 83, 84. Will modify all these 3 lines.
kkrugler
reviewed
Nov 7, 2020
| if (name != colInfo.name) return false; | ||
| if (precision != null ? !precision.equals(colInfo.precision) : colInfo.precision != null) return false; | ||
| return !(constraints != null ? !constraints.equals(colInfo.constraints) : colInfo.constraints != null); | ||
| if (!Objects.equals(precision, colInfo.precision)) return false; |
kkrugler
reviewed
Nov 7, 2020
| if (tag != null ? !tag.equals(htmlTag.tag) : htmlTag.tag != null) return false; | ||
| return clazz != null ? clazz.equals(htmlTag.clazz) : htmlTag.clazz == null; | ||
| if (!Objects.equals(tag, htmlTag.tag)) return false; | ||
| return Objects.equals(clazz, htmlTag.clazz); |
PeterAlfredLee
force-pushed
the
simplify-equals
branch
from
6d9639c to
e8e2c6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.