Simplify some test code by using method TikaTest#getResourceAsUrl and TikaTest#getResourceAsUri#385
Merged
kkrugler merged 3 commits intoapache:mainfrom Nov 18, 2020
Conversation
kkrugler
reviewed
Nov 17, 2020
| * @param name name of the desired resource | ||
| * @return A {@link java.net.URL} object or null | ||
| */ | ||
| public URL getResource(String name) { |
Contributor
There was a problem hiding this comment.
A more descriptive name - like getResourceAsUrl() - would help when reading the code. Wondering if a getResourceAsUri() should also be added.
Member
Author
There was a problem hiding this comment.
Sure. Will update change.
PeterAlfredLee
force-pushed
the
simplify_getResource
branch
from
f15697e to
8dfee9e
Compare
PeterAlfredLee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getResourceAsUrltoTikaTestgetResourceAsUritoTikaTestTikaTest#getResourceAsUrlandTikaTest#getResourceAsUri