Add extraction of layer names and textbox contents to PSDParser#69
Closed
kevindoyle wants to merge 3 commits intoapache:trunkfrom
Closed
Add extraction of layer names and textbox contents to PSDParser#69kevindoyle wants to merge 3 commits intoapache:trunkfrom
kevindoyle wants to merge 3 commits intoapache:trunkfrom
Conversation
Author
|
My apologies for opening this PR. The code is a mess and was meant for testing in our fork. |
kevindoyle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stepping through the byte stream to find text layer content ran into two blockers:
Txtcoming before the expectedTEXTkeyTxt TEXT, the key which IS consumed must be supported in order to get to the next key. The size of the data each key identifies is not easily determined.This implementation places the entire block of keyed data into a byte array and scans for the
TEXTkey.The dead-end code is commented out, saved for an especially rainy day when we can add support for all the keys and do this properly. (Should I do the right thing and put it on a separate branch?)
References:
PSD File Specification from 2013:
http://www.adobe.com/devnet-apps/photoshop/fileformatashtml/#50577409_pgfId-1031423
Unofficial PSD anatomy lesson from 2014:
https://github.com/layervault/psd.rb/wiki/Anatomy-of-a-PSD-File