Skip to content

fix for TIKA-1840 contributed by zetisam #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asfgit merged 2 commits into from
Jan 24, 2016
Merged

fix for TIKA-1840 contributed by zetisam #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52b82bd
fix for TIKA-1840 contributed by zetisam
zetisam Jan 22, 2016
7d43bd7
fix for TIKA-1840 contributed by zetisam -- fixed indentation
zetisam Jan 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tika-parsers/src/main/java/org/apache/tika/parser/microsoft/HSLFExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,17 @@ protected void parse(
// Now any embedded resources
handleSlideEmbeddedResources(slide, xhtml);

// TODO Find the Notes for this slide and extract inline

// Find the Notes for this slide and extract inline
HSLFNotes notes = slide.getNotes();
if (notes != null) {
xhtml.startElement("div", "class", "slide-notes");

textRunsToText(xhtml, notes.getTextParagraphs());

xhtml.endElement("div");
}


// Slide complete
xhtml.endElement("div");
Expand Down Expand Up @@ -198,7 +208,7 @@ private void extractMaster(XHTMLContentHandler xhtml, HSLFMasterSheet master) th
for (HSLFShape shape : shapes) {
if (shape != null && !HSLFMasterSheet.isPlaceholder(shape)) {
if (shape instanceof HSLFTextShape) {
HSLFTextShape tsh = (HSLFTextShape) shape;
HSLFTextShape tsh = (HSLFTextShape) shape;
String text = tsh.getText();
if (text != null) {
xhtml.element("p", text);
Expand Down