TIKA-1868 tika-server split into clean and standalone jar #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Understand based upon mailing email and jira defect this might be rejected.
But this the change I was intending to do, my original email was to understand if tika-server meant to be a shaded jar, which it appears to was intended to be.
But if you need to use classes that only live within tika-server it does make it harder to write custom code. If the guts of tika-server where put into another module maybe tika-server-internals then those that really need to used classes that just live in tika-server can use tika-server-internals and tika-server can be a simply shaded jar. Just a thought.