Skip to content

Fix for TIKA 1886#88

Merged
asfgit merged 3 commits intoapache:masterfrom
nandan-pc:TIKA-1886
Apr 19, 2016
Merged

Fix for TIKA 1886#88
asfgit merged 3 commits intoapache:masterfrom
nandan-pc:TIKA-1886

Conversation

@nandan-pc
Copy link
Contributor

Fix for issue : Tika -1886 provided by Nandan Padar Chandrashekar.

Summary :

  1. Added .hfa mime type to mime-type.xml
  2. Added related test case and resource file.

@nandan-pc nandan-pc changed the title Tika 1886 Fix for TIKA 1886 Mar 4, 2016
@Gagravarr
Copy link
Contributor

Few things:

  • Could you please put the new mimetype in alphabetical order, so between {{application/x-emf}} and {{application/x-filemaker}} ?
  • Could you try to find a smaller sample file? Ideally just a few kb in size
  • Could you please follow the test files naming convention for your test file? eg testHFA.hfa instead of a long hex string?

…changed the test file name and reduced sized of test file
@nandan-pc
Copy link
Contributor Author

Hi Nick,

Thanks for the review comments.

  1. Rearranged the order of mime type for mime-type x-erdas-hfa in tika-mimetypes.xml
  2. Changed the test file name to testHFA.hfa
  3. Reduced sized of test file size from 64 KB to 1KB.

Regards
Nandan Padar Chandrashekar

@asfgit asfgit merged commit db1c0e6 into apache:master Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants