Open
Conversation
- Moved tika-exiftool from separate project to parsers - Updated license headers - Removed author Javadoc - Fixed a few forbiddenapi violations
- Removed more author Javadocs
- Renamed ExecutableUtils to ExiftoolExecutableUtils - Changed ExifToolImageParserTest to skip when exiftool is not available
Conflicts: tika-exiftool/README.md
Contributor
|
@rgauss the work here is fantastic. This really could easily replace the one I wrote. If you don't have time I'll go ahead and update the wiki (which is a necessary first step since we have that wiki page now) here: http://wiki.apache.org/tika/EXIFToolParser I think that we can merge this in 1.14 |
Contributor
|
@rgauss I tried running this without exiftool installed, and I get: Test failures. The tests need to pass without exiftool can you help? |
Contributor
|
@rgauss after installing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution of tika-exiftool for review