Skip to content

TIKA-774: ExifTool Parser#92

Open
rgauss wants to merge 8 commits intoapache:masterfrom
AlfrescoArchive:tika-exiftool
Open

TIKA-774: ExifTool Parser#92
rgauss wants to merge 8 commits intoapache:masterfrom
AlfrescoArchive:tika-exiftool

Conversation

@rgauss
Copy link
Member

@rgauss rgauss commented Mar 21, 2016

Contribution of tika-exiftool for review

rgauss added 8 commits March 19, 2016 16:37
  - Moved tika-exiftool from separate project to parsers
  - Updated license headers
  - Removed author Javadoc
  - Fixed a few forbiddenapi violations
  - Removed more author Javadocs
  - Renamed ExecutableUtils to ExiftoolExecutableUtils
  - Changed ExifToolImageParserTest to skip when exiftool is not
available
Conflicts:
	tika-exiftool/README.md
@chrismattmann
Copy link
Contributor

@rgauss the work here is fantastic. This really could easily replace the one I wrote. If you don't have time I'll go ahead and update the wiki (which is a necessary first step since we have that wiki page now) here: http://wiki.apache.org/tika/EXIFToolParser I think that we can merge this in 1.14

@chrismattmann
Copy link
Contributor

@rgauss I tried running this without exiftool installed, and I get:


Results :

Failed tests: 
  ExiftoolExternalEmbedderTest>ExternalEmbedderTest.testEmbedStandardInputStream:277->ExternalEmbedderTest.embedInTempFile:251 Cannot run program "exiftool": error=2, No such file or directory
  ExiftoolExternalEmbedderTest>ExternalEmbedderTest.testEmbedTikaInputStream:288->ExternalEmbedderTest.embedInTempFile:251 Cannot run program "exiftool": error=2, No such file or directory

Test failures. The tests need to pass without exiftool can you help?

@chrismattmann
Copy link
Contributor

@rgauss after installing exiftool I now see these (different errors):

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.085 sec - in org.apache.tika.parser.xml.FictionBookParserTest
Running org.apache.tika.sax.PhoneExtractingContentHandlerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.086 sec - in org.apache.tika.sax.PhoneExtractingContentHandlerTest
Running org.apache.tika.TestParsers
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.148 sec - in org.apache.tika.TestParsers
Running org.apache.tika.utils.ServiceLoaderUtilsTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.08 sec - in org.apache.tika.utils.ServiceLoaderUtilsTest

Results :

Failed tests: 
  ForkParserIntegrationTest.testParserHandlingOfNonSerializable:210 expected:<Unable to serialize [ParseContext] to pass to the Fork...> but was:<Unable to serialize [AutoDetectParser] to pass to the Fork...>
Tests in error: 
  ForkParserIntegrationTest.testAttachingADebuggerOnTheForkedParserShouldWork:234 » Tika
  ForkParserIntegrationTest.testForkedPDFParsing:257 » Tika Unable to serialize ...
  ForkParserIntegrationTest.testForkedTextParsing:66 » Tika Unable to serialize ...

Tests run: 748, Failures: 1, Errors: 3, Skipped: 14

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Tika parent ................................. SUCCESS [  0.846 s]
[INFO] Apache Tika core ................................... SUCCESS [ 10.333 s]
[INFO] Apache Tika parsers ................................ FAILURE [03:42 min]
[INFO] Apache Tika XMP .................................... SKIPPED
[INFO] Apache Tika serialization .......................... SKIPPED
[INFO] Apache Tika batch .................................. SKIPPED
[INFO] Apache Tika language detection ..................... SKIPPED
[INFO] Apache Tika application ............................ SKIPPED
[INFO] Apache Tika OSGi bundle ............................ SKIPPED
[INFO] Apache Tika translate .............................. SKIPPED
[INFO] Apache Tika server ................................. SKIPPED
[INFO] Apache Tika examples ............................... SKIPPED
[INFO] Apache Tika Java-7 Components ...................... SKIPPED
[INFO] Apache Tika ........................................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:53 min
[INFO] Finished at: 2016-08-14T20:30:46-07:00
[INFO] Final Memory: 60M/942M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on project tika-parsers: There are test failures.
[ERROR] 
[ERROR] Please refer to /Users/mattmann/tmp/tika1.14/tika-parsers/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :tika-parsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants