TINKERPOP-1882 Apply range and limit steps as early as possible#1040
Merged
TINKERPOP-1882 Apply range and limit steps as early as possible#1040
Conversation
Contributor
|
please give me a little extra time to review this one - i had my head in other things last week. |
spmallette
reviewed
Jan 28, 2019
...org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/EarlyLimitStrategy.java
Show resolved
Hide resolved
spmallette
reviewed
Jan 28, 2019
...apache/tinkerpop/gremlin/process/traversal/strategy/optimization/EarlyLimitStrategyTest.java
Show resolved
Hide resolved
Contributor
|
Other than the few minor comments I made, I think this looks good. You have 100% coverage on the new strategy which is cool. I can't help thinking that there is yet some case that hasn't be covered but I'm not sure what case of significance isn't in your tests already. Only thing I could think of was maybe a test or two that has the I think it's worth mentioning this strategy in the upgrade docs and explaining its value. VOTE +1 |
asfgit
force-pushed
the
TINKERPOP-1882
branch
8 times, most recently
from
0b14107 to
a188a19
Compare
asfgit
force-pushed
the
TINKERPOP-1882
branch
from
a188a19 to
22d7b82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1882
docker/build.sh -t -i -npassed.VOTE +1