TINKERPOP-2144 Better handle Authenticator failures#1049
Merged
spmallette merged 1 commit intotp33from Feb 1, 2019
Merged
Conversation
spmallette
force-pushed
the
TINKERPOP-2144
branch
2 times, most recently
from
435de39 to
7ecdd5e
Compare
Failures occurred on the first round of a SASL request when the negotiator was being created and if an exception was tossed there neither the server nor driver handled the situation well. By explicitly capturing and handling it, we can now properly assert results in kerberos tests without having to try to assert server logs which wasn't always dependable for some reason. This change should prevent random failures around kerberos tests which has long been a problem.
spmallette
force-pushed
the
TINKERPOP-2144
branch
from
7ecdd5e to
117a386
Compare
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2144
Failures occurred on the first round of a SASL request when the negotiator was being created and if an exception was tossed there neither the server nor driver handled the situation well. By explicitly capturing and handling it, we can now properly assert results in kerberos tests without having to try to assert server logs which wasn't always dependable for some reason. This change should prevent random failures around kerberos tests which has long been a problem.
All tests pass with
docker/build.sh -t -n -iVOTE +1