Skip to content

Conversation

@jorgebay
Copy link
Contributor

@jorgebay jorgebay commented Feb 5, 2019

@jorgebay jorgebay requested a review from spmallette February 5, 2019 12:09
@spmallette
Copy link
Contributor

Please add an entry to CHANGELOG when you merge but otherwise VOTE +1


public class GraphBinaryMessageSerializerV1 extends AbstractMessageSerializer {
public static final String TOKEN_CUSTOM = "custom";
public static final String TOKEN_BUILDER = "builder";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new configuration option should be added to the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @dkuppitz , will do!

@jorgebay
Copy link
Contributor Author

jorgebay commented Feb 6, 2019

I've updated the docs and added an entry to the CHANGELOG.

@dkuppitz
Copy link
Contributor

dkuppitz commented Feb 6, 2019

VOTE +1

@jorgebay jorgebay merged commit 64e4964 into master Feb 6, 2019
@jorgebay jorgebay deleted the TINKERPOP-2150 branch February 6, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants