Skip to content

TINKERPOP-2020 Added withComputer() in javascript.#1152

Merged
spmallette merged 1 commit intotp33from
TINKERPOP-2020
Jul 5, 2019
Merged

TINKERPOP-2020 Added withComputer() in javascript.#1152
spmallette merged 1 commit intotp33from
TINKERPOP-2020

Conversation

@spmallette
Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/TINKERPOP-2020

Was able to remove all the test ignores around this. When merging forward I hope the remaining "computer" ignores can also drop:

'g_V_shortestPath': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_both_dedup_shortestPath': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_shortestPath_edgesIncluded': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_shortestPath_directionXINX': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_shortestPath_edgesXoutEX': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_shortestPath_edgesIncluded_edgesXoutEX': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_hasXname_markoX_shortestPath': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_shortestPath_targetXhasXname_markoXX': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_shortestPath_targetXvaluesXnameX_isXmarkoXX': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_hasXname_markoX_shortestPath_targetXhasLabelXsoftwareXX': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_hasXname_markoX_shortestPath_targetXhasXname_joshXX_distanceXweightX': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_hasXname_danielX_shortestPath_targetXhasXname_stephenXX_edgesXbothEXusesXX': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_hasXsong_name_MIGHT_AS_WELLX_shortestPath_targetXhasXsong_name_MAYBE_YOU_KNOW_HOW_I_FEELXX_edgesXoutEXfollowedByXX_distanceXweightX': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_hasXname_markoX_shortestPath_maxDistanceX1X': new IgnoreError(ignoreReason.computerNotSupported),
'g_V_hasXname_vadasX_shortestPath_distanceXweightX_maxDistanceX1_3X': new IgnoreError(ignoreReason.computerNotSupported),

Builds with mvn clean install -pl gremlin-javascript

VOTE +1

Copy link
Copy Markdown
Contributor

@jorgebay jorgebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this one @spmallette

I've highlighted a small issue below.

@spmallette spmallette force-pushed the TINKERPOP-2020 branch 2 times, most recently from 58f7b08 to b445089 Compare July 1, 2019 10:10
Copy link
Copy Markdown
Contributor

@jorgebay jorgebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, VOTE +1

@spmallette spmallette merged commit 060a914 into tp33 Jul 5, 2019
@spmallette spmallette deleted the TINKERPOP-2020 branch July 5, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants