TINKERPOP-2020 Added withComputer() in javascript.#1152
Merged
spmallette merged 1 commit intotp33from Jul 5, 2019
Merged
Conversation
jorgebay
reviewed
Jul 1, 2019
Contributor
jorgebay
left a comment
There was a problem hiding this comment.
Thanks for tackling this one @spmallette
I've highlighted a small issue below.
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/traversal-strategy.js
Outdated
Show resolved
Hide resolved
58f7b08 to
b445089
Compare
jorgebay
reviewed
Jul 1, 2019
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/traversal-strategy.js
Outdated
Show resolved
Hide resolved
b445089 to
27e63bc
Compare
27e63bc to
060a914
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2020
Was able to remove all the test ignores around this. When merging forward I hope the remaining "computer" ignores can also drop:
tinkerpop/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js
Lines 84 to 98 in f7aeac4
Builds with
mvn clean install -pl gremlin-javascriptVOTE +1