TINKERPOP-2265 Deprecate remote Traversal.sideEffects#1162
Conversation
divijvaidya
left a comment
divijvaidya
left a comment
There was a problem hiding this comment.
This should impact Message Ops OPS_GATHER & OPS_KEYS in TraversalOpProcessor as well. Please mark them as deprecated or add an appropriate comment over the expected usage.
spmallette
force-pushed
the
TINKERPOP-2265
branch
from
c3dd37b to
fc0d463
Compare
|
@divijvaidya thanks - i shouldn't have missed all those. Should look better now. |
|
I am familiar with the server and the java driver code changes and they look good. VOTE +1 |
jorgebay
left a comment
jorgebay
left a comment
There was a problem hiding this comment.
Thanks for adding a code example into how to migrate existing code.
I've added a few comments below.
gremlin-dotnet/src/Gremlin.Net/Driver/Remote/DriverRemoteTraversalSideEffects.cs
Outdated
Show resolved
Hide resolved
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/ITraversalSideEffects.cs
Outdated
Show resolved
Hide resolved
spmallette
force-pushed
the
TINKERPOP-2265
branch
from
fc0d463 to
d05ca6d
Compare
spmallette
force-pushed
the
TINKERPOP-2265
branch
from
d05ca6d to
bf2803e
Compare
FlorianHockmann
left a comment
FlorianHockmann
left a comment
There was a problem hiding this comment.
I just added one comment, but the changes look good in general and I like that we can get rid of this functionality in the future :)
| public static final String OPS_CLOSE = "close"; | ||
|
|
||
| /** | ||
| * @deprecated As of release 3.3.8, not directly replaced in the protocol as side-effect retrieval after |
There was a problem hiding this comment.
(nitpick) I think these tokens should also be deprecated the same way in Gremlin.Net's Token class (and I don't know about gremlin-python and gremlin-javascript).
There was a problem hiding this comment.
ok - added the obsolete annotation for .NET. javascript doesn't have side-effect functionality so nothing to deprecate there. i thought about python but it meant adding the deprecations library (i think) and i didnt' want to add a dependency (maybe we should...i dunno - perhaps that's a separate decision for newer versions of gremlin-python). how does everything look now?
There was a problem hiding this comment.
Looks good to me in general, but it looks like you need to add a using directive in Tokens.cs which lets the build fail right now.
spmallette
force-pushed
the
TINKERPOP-2265
branch
from
bf2803e to
36b06cd
Compare
Users should not prefer use of cap() to directly return side-effects as part of standard traversal iteration.
spmallette
force-pushed
the
TINKERPOP-2265
branch
from
36b06cd to
b355d87
Compare
4 participants
https://issues.apache.org/jira/browse/TINKERPOP-2265
Users should not prefer use of
cap()to directly return side-effects as part of standard traversal iteration. Expecting removal of the deprecated bits in 3.5.0.VOTE +1