TINKERPOP-2284 Added elementMap() step#1189
Merged
spmallette merged 1 commit intotp34from Sep 13, 2019
Merged
Conversation
Member
FlorianHockmann
left a comment
FlorianHockmann
left a comment
There was a problem hiding this comment.
I reviewed the docs and changes to the .NET and Python code and only found one nit.
VOTE +1
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs
Outdated
Show resolved
Hide resolved
Given that we only return reference objects for graph elements now, there is a lot of extra project()/valueMap() work to do for the simple and common need to return all the structure of a graph element. elementMap() simplifies all that to a single step without a ton of options and added features.
spmallette
force-pushed
the
TINKERPOP-2284
branch
from
3cf9f34 to
d4f7e9d
Compare
jorgebay
approved these changes
Sep 10, 2019
Contributor
jorgebay
left a comment
jorgebay
left a comment
There was a problem hiding this comment.
I really liked the approach on the new step.
VOTE +1
| ---- | ||
|
|
||
| It is important to note that the map of a vertex assumes that cardinality for each key is `single` and if it is `list` | ||
| then only the first item encountered will be returned. As `single` is the more common cardinality for properties this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2284
Given that we only return reference objects for graph elements now, there is a lot of extra
project()/valueMap()work to do for the simple and common need to return all the structure of a graph element.elementMap()simplifies all that to a single step without a ton of options and added features.All tests pass with
docker/build.sh -t -iVOTE +1