Removing '_' from from GraphTraversal Method#1208
Closed
ktstowell wants to merge 1 commit into
Closed
Conversation
Removing '_' from `from` GraphTraversal Method method to match documentation. - Would require Major version bump due to breakages in backwards compatibility. - Could be a patch if we left `from_` unaltered, and added `from` which proxied the same thing.
Contributor
|
Hi, as I understood it, the idea is to futureproof https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import note that we do mention the underscore for JS in http://tinkerpop.apache.org/docs/current/reference/#from-step |
Author
|
Awesome! Thanks for clearing that up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing '_' from
fromGraphTraversal Method method to match documentation (http://tinkerpop.apache.org/docs/current/reference/#addedge-step - please notice step "7" api example.)from_unaltered, and addedfromwhich proxied the same thing.This is largely just to start a conversation so that code can be referenced in a issue.