TINKERPOP-2310 and TINKERPOP-2311 Folllow up refactoring after TraversalStrategy changes#1216
Merged
spmallette merged 2 commits intomasterfrom Nov 18, 2019
Merged
TINKERPOP-2310 and TINKERPOP-2311 Folllow up refactoring after TraversalStrategy changes#1216spmallette merged 2 commits intomasterfrom
spmallette merged 2 commits intomasterfrom
Conversation
Minor refactoring to polish up toList() usage a bit in favor of foreach and Iterator usage where sensible.
jorgebay
approved these changes
Nov 7, 2019
| * Set the {@link org.apache.tinkerpop.gremlin.process.traversal.step.TraversalParent} {@link Step} that is | ||
| * the parent of this traversal. Traversals can be nested and this is the means by which the traversal tree is | ||
| * connected. | ||
| * connected. If there is no parent, then it should be a {@link EmptyStep}. |
Contributor
There was a problem hiding this comment.
:+100 for the clarification in the javadoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2310
https://issues.apache.org/jira/browse/TINKERPOP-2311
A few added refactoring opportunities were noticed as a result of TINKERPOP-1568. Basically,
TraversalStrategiesnow implementsIterableand the semantics ofTraversal.isRoot()have been narrowed to only check forEmptySteprather than also checking fornull.All tests pass with
docker/build.sh -t -n -iVOTE +1