gremlin-python: add session mode client#1264
gremlin-python: add session mode client#1264heljoyLiu wants to merge 2 commits intoapache:3.4-devfrom
Conversation
|
hi @spmallette , it's for |
|
I referenced this one from #1263 ( Ideally we need:
I think for the first two items we can just refer to this feature generally - no need to have one changelog/upgrade section per language. |
| # close session, 'gremlin' in args as tips and not be executed actually | ||
| gremlin = args.get('gremlin') | ||
| if not gremlin: | ||
| args['gremlin'] = 'session.close()' |
There was a problem hiding this comment.
As in the other languages, I'd prefer we not include any extra arguments to the "close" message. Please modify this python PR to match what was done on the other language PRs.
There was a problem hiding this comment.
en. I will remove this like PR in .Net
|
@heljoyLiu If you'd like to try to include the documentation changes I suggested above on this PR that would be great, otherwise I will look to add them myself on merge. Also note that you intended to fix this in Javascript: https://github.com/apache/tinkerpop/pull/1251/files#diff-9ec1348d608a722cece8543e6db87a23R385 If you'd like to add that here on this PR that will be fine, though for some reason you target As a reminder to myself, on the merge of this one to https://issues.apache.org/jira/browse/TINKERPOP-2336 in the context of python/js/.net merging to Well, I hope I've captured all the loose ends on this "session" feature. If anyone has anything else they might add please comment. Thanks. |
ok, I will re-target to |
I see, another PR for |
|
thanks @spmallette, I will close this PR |
No description provided.