TINKERPOP-2514 Prevent two request ids to be pending at same time#1391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2514
The driver throws an error if the same request id is already pending in the queue which is the solution suggested on the ticket. I think that largely solves this specific problem. I suppose there might be ways to still to trick out the server but I wonder if we need to try to account for that as this doesn't seem like a normal operating condition. Perhaps this is a good enough fix.
All tests pass with
mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=falseVOTE +1