TINKERPOP-2735: Backport fix to close request error in UnifiedChannelizer to 3.5-dev#1705
Merged
spmallette merged 1 commit intoapache:3.5-devfrom Jun 16, 2022
Conversation
…ing close requests
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #1705 +/- ##
===========================================
- Coverage 63.35% 63.27% -0.09%
===========================================
Files 23 23
Lines 3553 3553
===========================================
- Hits 2251 2248 -3
- Misses 1129 1131 +2
- Partials 173 174 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix to the error message on session close reported in https://issues.apache.org/jira/browse/TINKERPOP-2735.
Session
closerequest will outputUnrecognized contenterror message in 3.5.x server, the fix is in 3.6.0 whereUnifiedHandlerhas an added check to handle close requests, whereas the 3.5.x server does not, and that causes the request to fall through into the exception here with a null content type for the gremlin args field.This PR backports that check in 3.6 for
closerequests into 3.5-dev