Skip to content

Comments

TINKERPOP-2735: Backport fix to close request error in UnifiedChannelizer to 3.5-dev#1705

Merged
spmallette merged 1 commit intoapache:3.5-devfrom
xiazcy:TINKERPOP-2735-backport-session-close-errr-fix
Jun 16, 2022
Merged

TINKERPOP-2735: Backport fix to close request error in UnifiedChannelizer to 3.5-dev#1705
spmallette merged 1 commit intoapache:3.5-devfrom
xiazcy:TINKERPOP-2735-backport-session-close-errr-fix

Conversation

@xiazcy
Copy link
Contributor

@xiazcy xiazcy commented Jun 14, 2022

A fix to the error message on session close reported in https://issues.apache.org/jira/browse/TINKERPOP-2735.

Session close request will output Unrecognized content error message in 3.5.x server, the fix is in 3.6.0 where UnifiedHandler has an added check to handle close requests, whereas the 3.5.x server does not, and that causes the request to fall through into the exception here with a null content type for the gremlin args field.

This PR backports that check in 3.6 for close requests into 3.5-dev

@codecov-commenter
Copy link

Codecov Report

Merging #1705 (ae720be) into 3.5-dev (287499e) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           3.5-dev    #1705      +/-   ##
===========================================
- Coverage    63.35%   63.27%   -0.09%     
===========================================
  Files           23       23              
  Lines         3553     3553              
===========================================
- Hits          2251     2248       -3     
- Misses        1129     1131       +2     
- Partials       173      174       +1     
Impacted Files Coverage Δ
gremlin-go/driver/client.go 79.12% <0.00%> (-3.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287499e...ae720be. Read the comment docs.

@spmallette spmallette merged commit c59ecbb into apache:3.5-dev Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants