TINKERPOP-2765 Fix concurrency issue during script translation in the GremlinGroovyScriptEngine.#1778
Merged
spmallette merged 1 commit intoapache:3.6-devfrom Aug 10, 2022
Conversation
… GremlinGroovyScriptEngine.
Codecov Report
@@ Coverage Diff @@
## 3.6-dev #1778 +/- ##
========================================
Coverage 64.06% 64.06%
========================================
Files 23 23
Lines 3679 3679
========================================
Hits 2357 2357
Misses 1154 1154
Partials 168 168 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same changes as #1768 except for 3.6-dev.
From PR 1768:
An issue occurs when the GremlinGroovyScriptEngine is called from multiple threads to evaluate bytecode that contains lambdas. The default translator is not thread-safe which results in queries being interlaced with one another. This is fixed by creating a new instance of the translator per translation so that the translation process isn't interfered with. This primarily affects the UnifiedChannelizer because it currently uses the same instance of the translator from multiple threads.
Fixes https://issues.apache.org/jira/browse/TINKERPOP-2765