Skip to content

Better error for addE() where the FROM or TO traverser gives no results #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
metawilm-aws wants to merge 1 commit into from
Closed

Better error for addE() where the FROM or TO traverser gives no results #1845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions ...core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,17 @@ public Map<K, V> projectTraverser(final Traverser.Admin<S> traverser) {
if (null == this.barrierStep) {
if (this.valueTraversal.hasNext())
map.put(TraversalUtil.applyNullable(traverser, this.keyTraversal), (V) this.valueTraversal.next());
} else if (this.barrierStep.hasNextBarrier())
map.put(TraversalUtil.applyNullable(traverser, this.keyTraversal), (V) this.barrierStep.nextBarrier());


} else if (this.barrierStep.hasNextBarrier()) {
try {
map.put(TraversalUtil.applyNullable(traverser, this.keyTraversal), (V) this.barrierStep.nextBarrier());
} catch (IllegalArgumentException e) { // as thrown by TraversalUtil.apply()
throw new IllegalStateException(String.format(
"group().by() failed because by() traversal (which is: %s) failed with: %s",
keyTraversal.toString(), e.getMessage()));
}
}
return map;
}

Expand Down Expand Up @@ -209,4 +218,4 @@ else if (null != objectB)
return mapA;
}
}
}
}