Skip to content

Cherry picking commits from PR #1829#1851

Merged
xiazcy merged 3 commits into3.5-devfrom
go-embbed-cherry-pick
Nov 7, 2022
Merged

Cherry picking commits from PR #1829#1851
xiazcy merged 3 commits into3.5-devfrom
go-embbed-cherry-pick

Conversation

@xiazcy
Copy link
Copy Markdown
Contributor

@xiazcy xiazcy commented Nov 4, 2022

Original PR by @remiphilippe to use Go embed for logging resources #1829.

Using a throw-away branch to make sure I'm cherry picking the commits correctly to merge into 3.5-dev.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #1851 (ffe50d0) into 3.5-dev (d66ce68) will increase coverage by 5.79%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             3.5-dev    #1851      +/-   ##
=============================================
+ Coverage      63.58%   69.38%   +5.79%     
- Complexity         0     8920    +8920     
=============================================
  Files             23      861     +838     
  Lines           3636    40860   +37224     
  Branches           0     5385    +5385     
=============================================
+ Hits            2312    28350   +26038     
- Misses          1145    10605    +9460     
- Partials         179     1905    +1726     
Impacted Files Coverage Δ
gremlin-go/driver/error_codes.go 100.00% <100.00%> (ø)
gremlin-go/driver/logger.go 91.66% <100.00%> (ø)
...mlin/structure/util/empty/EmptyVertexProperty.java 35.71% <0.00%> (ø)
...pop/gremlin/process/computer/VertexComputeKey.java 90.00% <0.00%> (ø)
...erpop/gremlin/util/function/TraversableLambda.java 0.00% <0.00%> (ø)
...kerpop/gremlin/neo4j/process/traversal/LabelP.java 0.00% <0.00%> (ø)
...va/org/apache/tinkerpop/gremlin/util/TimeUtil.java 38.88% <0.00%> (ø)
...p/gremlin/process/traversal/step/LocalBarrier.java 100.00% <0.00%> (ø)
...l/strategy/verification/VerificationException.java 75.00% <0.00%> (ø)
...erser/LP_NL_O_OB_P_S_SE_SL_TraverserGenerator.java 100.00% <0.00%> (ø)
... and 830 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiazcy xiazcy merged commit e650d23 into 3.5-dev Nov 7, 2022
@xiazcy xiazcy deleted the go-embbed-cherry-pick branch November 7, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants