TINKERPOP-2480 Add User-Agent to Go Driver #1877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cole-Greer
changed the title
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #1877 +/- ##
==========================================
Coverage 69.41% 69.41%
Complexity 8920 8920
==========================================
Files 861 862 +1
Lines 40868 40896 +28
Branches 5388 5388
==========================================
+ Hits 28368 28390 +22
- Misses 10590 10598 +8
+ Partials 1910 1908 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Cole-Greer
force-pushed
the
cole/user-agent-go
branch
from
d810add to
fa64a6f
Compare
Contributor
|
LGTM |
Cole-Greer
force-pushed
the
cole/user-agent-go
branch
from
fa64a6f to
aa29359
Compare
User agent follows the form of [Application Name] [GLV Name].[Version] [Language Runtime Version] [OS].[Version] [CPU Architecture] New feature in the go driver to send a user agent header during the web socket handshake for new connections. This behavior is enabled by default but can be disabled by setting connectionSettings.enableUserAgent to false. Note: Due to limitations with the language, the OS version cannot be detected in Go. Therefore the OS version will be reported as "NotAvailable".
Cole-Greer
force-pushed
the
cole/user-agent-go
branch
from
aa29359 to
dd5f49b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards TINKERPOP-2480
Adds a user agent to gremlin-go which is sent as a request header during the web socket handshake.
User agent follows the form of [Application Name] [GLV Name].[Version] [Language Runtime Version] [OS].[Version] [CPU Architecture]
This behavior is enabled by default but can be disabled by setting the EnableUserAgentOnConnect setting to false.
Note: There are no tests included as part of this PR. My intention is to add integration tests to ensure that the user agent is being sent correctly once TINKERPOP-2819 has been merged. The existing go glv tests are sufficient to show that this change does not introduce any faults into the driver. I have conducted manual tests to ensure that the changes are currently functioning correctly. My thoughts are that with a potential release approaching, it is worthwhile to have the user agent introduced now, with full validation coming soon.