Skip to content

Conversation

@spmallette
Copy link
Contributor

https://issues.apache.org/jira/browse/TINKERPOP-2804

Taking this approach makes it easier for providers to reference the files from the classpath, otherwise they likely need to have copies of them on the local file system which isn't so good. This is a breaking change but it only affects providers. They will have a minor adjustment to make to their test infrastructure on upgrade.

VOTE +1

@vkagamlyk
Copy link
Contributor

.net local test run without docker: System.IO.DirectoryNotFoundException : Could not find a part of the path 'C:\_Projects\tinkerpop-apache\gremlin-test\features'.
because https://github.com/apache/tinkerpop/blob/3.6-dev/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs#L385

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #1878 (f394d8f) into 3.6-dev (053064b) will decrease coverage by 5.39%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             3.6-dev    #1878      +/-   ##
=============================================
- Coverage      69.46%   64.06%   -5.40%     
=============================================
  Files            875       23     -852     
  Lines          41772     3679   -38093     
  Branches        5627        0    -5627     
=============================================
- Hits           29016     2357   -26659     
+ Misses         10770     1154    -9616     
+ Partials        1986      168    -1818     
Impacted Files Coverage Δ
...pop/gremlin/driver/message/ResponseStatusCode.java
...emlin/structure/util/DefaultCloseableIterator.java
...apache/tinkerpop/gremlin/server/handler/Frame.java
...emlin/groovy/jsr223/GremlinGroovyScriptEngine.java
...p/gremlin/process/traversal/step/map/MathStep.java
...e/tinkerpop/gremlin/process/traversal/GraphOp.java
...a/org/apache/tinkerpop/gremlin/driver/Cluster.java
...pop/gremlin/process/computer/MemoryComputeKey.java
...nkerpop/gremlin/util/function/BulkSetSupplier.java
...ategy/optimization/IncidentToAdjacentStrategy.java
... and 842 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vkagamlyk
Copy link
Contributor

VOTE +1

Taking this approach makes it easier for providers to reference the files from the classpath, otherwise they likely need to have copies of them on the local file system which isn't so good. This is a breaking change but it only affects providers. They will have a minor adjustment to make to their test infrastructure on upgrade.
@spmallette spmallette merged commit ca81111 into 3.6-dev Dec 5, 2022
@spmallette spmallette deleted the TINKERPOP-2804 branch December 5, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants