TINKERPOP-2840 Fixed Flaky Tests#1898
Closed
priyanka-28 wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
xiazcy
pushed a commit
that referenced
this pull request
Dec 21, 2022
Contributor
|
Cherry-picked fix to 8f62cbb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests in IteratorUtilsTest and ParameterizedGroovyTranslatorTest express non-deterministic behavior and change the order of the attributes. The fix is changing HashMap to LinkedHashMap and changing HashSet to LinkedHashSet to guarantee determinism.
[Issue] (https://issues.apache.org/jira/browse/TINKERPOP-2840)
After resolving the issues successfully, the tests pass with NonDex -