Skip to content

TINKERPOP-2842 Parsed requestId in GremlinScriptChecker#1916

Merged
spmallette merged 1 commit into3.5-devfrom
TINKERPOP-2842
Jan 4, 2023
Merged

TINKERPOP-2842 Parsed requestId in GremlinScriptChecker#1916
spmallette merged 1 commit into3.5-devfrom
TINKERPOP-2842

Conversation

@spmallette
Copy link
Contributor

@spmallette spmallette commented Dec 22, 2022

https://issues.apache.org/jira/browse/TINKERPOP-2842

Pretty straightforward - just added another thing to parse with the GremlinScriptChecker. Did some basic tests to make sure there was no real performance change as a result of this. cc/ @rdtr

VOTE +1

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #1916 (a2f629e) into 3.5-dev (8f62cbb) will increase coverage by 0.01%.
The diff coverage is 95.00%.

@@              Coverage Diff              @@
##             3.5-dev    #1916      +/-   ##
=============================================
+ Coverage      69.33%   69.35%   +0.01%     
- Complexity      8939     8946       +7     
=============================================
  Files            865      865              
  Lines          41064    41074      +10     
  Branches        5413     5417       +4     
=============================================
+ Hits           28470    28485      +15     
+ Misses         10678    10674       -4     
+ Partials        1916     1915       -1     
Impacted Files Coverage Δ
...op/gremlin/groovy/jsr223/GremlinScriptChecker.java 92.85% <95.00%> (-1.59%) ⬇️
...cess/computer/traversal/step/map/ShortestPath.java 57.89% <0.00%> (-5.27%) ⬇️
...versal/step/map/ShortestPathVertexProgramStep.java 90.00% <0.00%> (-3.34%) ⬇️
...e/tinkerpop/gremlin/server/util/MetricManager.java 51.91% <0.00%> (-0.55%) ⬇️
...rg/apache/tinkerpop/gremlin/driver/Connection.java 63.75% <0.00%> (ø)
...emlin/groovy/jsr223/GremlinGroovyScriptEngine.java 71.27% <0.00%> (+0.36%) ⬆️
...pache/tinkerpop/gremlin/driver/ConnectionPool.java 29.28% <0.00%> (+0.62%) ⬆️
...apache/tinkerpop/gremlin/server/GremlinServer.java 57.07% <0.00%> (+1.46%) ⬆️
...java/org/apache/tinkerpop/gremlin/driver/Host.java 37.77% <0.00%> (+2.22%) ⬆️
.../gremlin/driver/exception/ConnectionException.java 44.44% <0.00%> (+22.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vkagamlyk
Copy link
Contributor

VOTE +1

@spmallette spmallette merged commit 0adaa5f into 3.5-dev Jan 4, 2023
@spmallette spmallette deleted the TINKERPOP-2842 branch January 4, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants