TINKERPOP-2842 Parsed requestId in GremlinScriptChecker#1916
Merged
spmallette merged 1 commit into3.5-devfrom Jan 4, 2023
Merged
TINKERPOP-2842 Parsed requestId in GremlinScriptChecker#1916spmallette merged 1 commit into3.5-devfrom
spmallette merged 1 commit into3.5-devfrom
Conversation
vkagamlyk
reviewed
Dec 22, 2022
...roovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinScriptCheckerTest.java
Show resolved
Hide resolved
1ad7875 to
a2f629e
Compare
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #1916 +/- ##
=============================================
+ Coverage 69.33% 69.35% +0.01%
- Complexity 8939 8946 +7
=============================================
Files 865 865
Lines 41064 41074 +10
Branches 5413 5417 +4
=============================================
+ Hits 28470 28485 +15
+ Misses 10678 10674 -4
+ Partials 1916 1915 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2842
Pretty straightforward - just added another thing to parse with the
GremlinScriptChecker. Did some basic tests to make sure there was no real performance change as a result of this. cc/ @rdtrVOTE +1