Skip to content

[TINKERPOP-2849] fix for GraphTraversalSource.With#1917

Merged
xiazcy merged 2 commits intoapache:3.5-devfrom
Bit-Quill:valentyn/TINKERPOP-2849
Jan 3, 2023
Merged

[TINKERPOP-2849] fix for GraphTraversalSource.With#1917
xiazcy merged 2 commits intoapache:3.5-devfrom
Bit-Quill:valentyn/TINKERPOP-2849

Conversation

@vkagamlyk
Copy link
Contributor

Fix for incorrect implementation for GraphTraversalSource.With in gremlin-go

https://issues.apache.org/jira/browse/TINKERPOP-2849

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #1917 (b2fafce) into 3.5-dev (8f62cbb) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             3.5-dev    #1917      +/-   ##
=============================================
- Coverage      69.33%   69.30%   -0.03%     
+ Complexity      8939     8935       -4     
=============================================
  Files            865      865              
  Lines          41064    41076      +12     
  Branches        5413     5413              
=============================================
- Hits           28470    28469       -1     
- Misses         10678    10690      +12     
- Partials        1916     1917       +1     
Impacted Files Coverage Δ
gremlin-go/driver/graphTraversalSource.go 87.37% <100.00%> (+1.66%) ⬆️
gremlin-go/driver/request.go 78.89% <0.00%> (-6.43%) ⬇️
...cess/computer/traversal/step/map/ShortestPath.java 57.89% <0.00%> (-5.27%) ⬇️
...versal/step/map/ShortestPathVertexProgramStep.java 90.00% <0.00%> (-3.34%) ⬇️
...rg/apache/tinkerpop/gremlin/driver/Connection.java 63.12% <0.00%> (-0.63%) ⬇️
...e/tinkerpop/gremlin/server/util/MetricManager.java 51.91% <0.00%> (-0.55%) ⬇️
...nkerpop/gremlin/groovy/engine/GremlinExecutor.java 87.28% <0.00%> (-0.43%) ⬇️
...apache/tinkerpop/gremlin/server/GremlinServer.java 56.09% <0.00%> (+0.48%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiazcy
Copy link
Contributor

xiazcy commented Dec 22, 2022

LGTM VOTE +1

@spmallette
Copy link
Contributor

VOTE +1, pending changelog entry

@xiazcy xiazcy merged commit 2c63a41 into apache:3.5-dev Jan 3, 2023
@xiazcy xiazcy deleted the valentyn/TINKERPOP-2849 branch April 9, 2024 15:39
@xiazcy xiazcy restored the valentyn/TINKERPOP-2849 branch April 9, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants