TINKERPOP-2905 Always pass logHandler to transporter#1990
Merged
xiazcy merged 1 commit intoapache:3.5-devfrom Mar 14, 2023
Merged
TINKERPOP-2905 Always pass logHandler to transporter#1990xiazcy merged 1 commit intoapache:3.5-devfrom
logHandler to transporter#1990xiazcy merged 1 commit intoapache:3.5-devfrom
Conversation
disq
commented
Mar 14, 2023
| transporter = &gorillaTransporter{url: url, connSettings: connSettings, writeChannel: make(chan []byte, writeChannelSizeDefault), wg: &sync.WaitGroup{}} | ||
| transporter = &gorillaTransporter{ | ||
| url: url, | ||
| logHandler: logHandler, |
Contributor
Author
There was a problem hiding this comment.
The whole block was reformatted and logHandler was added.
Contributor
|
@disq thank you for fixing this! VOTE +1 |
Contributor
|
Thanks @disq, this looks good to me. Just so you know what happens next, our review process requires 3 committers to give the PR a VOTE +1 in the comments here (Or single VOTE +1 with a 7 day waiting period). Non-committers can give non-binding votes for changes they support. Once the change is approved one of the committers will merge the PR into the appropriate branches. The specifics are all defined here. VOTE +1 (non-binding) |
Contributor
|
VOTE +1 |
Contributor
|
LGTM. VOTE +1. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.