Skip to content

Conversation

@acoady
Copy link
Contributor

@acoady acoady commented Mar 30, 2023

@codecov-commenter
Copy link

Codecov Report

Merging #2008 (bc4e6ab) into 3.5-dev (8267422) will increase coverage by 0.49%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             3.5-dev    #2008      +/-   ##
=============================================
+ Coverage      69.37%   69.87%   +0.49%     
+ Complexity      8959     8953       -6     
=============================================
  Files            866      841      -25     
  Lines          41183    37436    -3747     
  Branches        5423     5423              
=============================================
- Hits           28570    26157    -2413     
+ Misses         10704     9543    -1161     
+ Partials        1909     1736     -173     
Impacted Files Coverage Δ
.../org/apache/tinkerpop/gremlin/driver/Settings.java 70.58% <100.00%> (+0.21%) ⬆️
...oovy/jsr223/customizer/FileSandboxExtension.groovy 78.57% <100.00%> (+0.79%) ⬆️
.../org/apache/tinkerpop/gremlin/server/Settings.java 82.71% <100.00%> (+0.10%) ⬆️

... and 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiazcy
Copy link
Contributor

xiazcy commented Mar 30, 2023

LGTM. VOTE +1.

@vkagamlyk
Copy link
Contributor

VOTE +1

1 similar comment
@kenhuuu
Copy link
Contributor

kenhuuu commented Mar 31, 2023

VOTE +1

@xiazcy xiazcy merged commit 78d2db2 into apache:3.5-dev Apr 3, 2023
@acoady acoady deleted the TINKERPOP-2902 branch April 3, 2023 17:33
xiazcy added a commit that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants