Rename RangeByIsCountStrategy to CountStrategy in Gremlin.NET.#2175
Merged
xiazcy merged 1 commit intoapache:3.5-devfrom Aug 8, 2023
Merged
Conversation
…hange has originally been done in f08d44f.
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #2175 +/- ##
=============================================
- Coverage 69.94% 69.93% -0.02%
=============================================
Files 866 24 -842
Lines 41068 3449 -37619
Branches 5476 0 -5476
=============================================
- Hits 28726 2412 -26314
+ Misses 10440 860 -9580
+ Partials 1902 177 -1725 see 842 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
FlorianHockmann
approved these changes
Jul 31, 2023
Member
FlorianHockmann
left a comment
FlorianHockmann
left a comment
There was a problem hiding this comment.
Oh wow, that's an old issue. Looks like the PR where the renaming was done happened after I created the PR to add the first version of Gremlin.Net: #600 and therefore apparently missed the renaming.
VOTE +1
Note that we are currently preparing the next lines of releases and are therefore in code freeze. So this will probably have to wait until after the release.
Contributor
|
VOTE +1. I will merge this one through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change has originally been done in f08d44f.