Skip to content

Fixed deserialization of element properties for GraphBinary#2304

Merged
vkagamlyk merged 1 commit intoapache:masterfrom
Bit-Quill:valentyn/element-property-deserialization-fix
Oct 23, 2023
Merged

Fixed deserialization of element properties for GraphBinary#2304
vkagamlyk merged 1 commit intoapache:masterfrom
Bit-Quill:valentyn/element-property-deserialization-fix

Conversation

@vkagamlyk
Copy link
Copy Markdown
Contributor

Elements properties can have parent element not set, PR fix this

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.80%. Comparing base (6a0f254) to head (ab0888c).
Report is 1105 commits behind head on master.

Files with missing lines Patch % Lines
...mlin/structure/io/binary/types/EdgeSerializer.java 87.50% 0 Missing and 1 partial ⚠️
...in/structure/io/binary/types/VertexSerializer.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2304      +/-   ##
============================================
- Coverage     75.82%   75.80%   -0.03%     
+ Complexity    12744    12742       -2     
============================================
  Files          1062     1062              
  Lines         64412    64424      +12     
  Branches       7118     7122       +4     
============================================
- Hits          48841    48836       -5     
- Misses        12924    12943      +19     
+ Partials       2647     2645       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Cole-Greer
Copy link
Copy Markdown
Contributor

VOTE +1

2 similar comments
@xiazcy
Copy link
Copy Markdown
Contributor

xiazcy commented Oct 23, 2023

VOTE +1

@vkagamlyk
Copy link
Copy Markdown
Contributor Author

VOTE +1

@vkagamlyk vkagamlyk merged commit e5a337b into apache:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants