Skip to content

Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet#2324

Merged
FlorianHockmann merged 1 commit into3.5-devfrom
dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1
Nov 15, 2023
Merged

Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet#2324
FlorianHockmann merged 1 commit into3.5-devfrom
dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 3, 2023

Bumps xunit from 2.5.3 to 2.6.1.

Commits
  • 9f1684f v2.6.1
  • 5d9ef4b Remove unnecessary XUNIT_VALUETASK definition
  • 0266bac Latest assertions
  • fb3c3cf Remove all ValueTask support from assertions
  • 801790c Reconcile AcceptanceTestAssembly and friends with v3
  • f244cc8 More shared assertion tests that shouldn't return ValueTask
  • 262dd72 Shared assertion tests cannot return ValueTask
  • 36bbf77 Bump up to v2.6.1-pre
  • 6a07b95 v2.6.0
  • 5a7297e #2806: Performance improvements in Assert.Equal (v2)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added .NET dependencies Pull requests that update a dependency file labels Nov 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c26dfd) 69.93% compared to head (4613832) 69.94%.

Additional details and impacted files
@@              Coverage Diff              @@
##             3.5-dev    #2324      +/-   ##
=============================================
+ Coverage      69.93%   69.94%   +0.01%     
- Complexity         0     9031    +9031     
=============================================
  Files             24      866     +842     
  Lines           3449    41068   +37619     
  Branches           0     5476    +5476     
=============================================
+ Hits            2412    28727   +26315     
- Misses           860    10442    +9582     
- Partials         177     1899    +1722     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot force-pushed the dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 branch from d1392be to 1b4d1ce Compare November 13, 2023 12:55
@FlorianHockmann FlorianHockmann force-pushed the dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 branch from 1b4d1ce to 5a35850 Compare November 15, 2023 12:32
Bumps [xunit](https://github.com/xunit/xunit) from 2.5.3 to 2.6.1.
- [Commits](xunit/xunit@2.5.3...2.6.1)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Had to fix two tests due to a type issue related to `dynamic`:

```
Failed Gremlin.Net.UnitTest.Structure.IO.GraphSON.GraphSONReaderTests.ShouldDeserializeEmptyGList(version: 3) [10 ms]
gremlin-dotnet-integration-tests    |   Error Message:
gremlin-dotnet-integration-tests    |    Microsoft.CSharp.RuntimeBinder.RuntimeBinderException : The type 'object' must be a non-nullable value type in order to use it as parameter 'T' in the generic type or method 'Xunit.Assert.Equal<T>(T[], T[])'
gremlin-dotnet-integration-tests    |   Stack Trace:
gremlin-dotnet-integration-tests    |      at CallSite.Target(Closure , CallSite , Type , Object[] , Object )
gremlin-dotnet-integration-tests    |    at System.Dynamic.UpdateDelegates.UpdateAndExecuteVoid3[T0,T1,T2](CallSite site, T0 arg0, T1 arg1, T2 arg2)
gremlin-dotnet-integration-tests    |    at Gremlin.Net.UnitTest.Structure.IO.GraphSON.GraphSONReaderTests.ShouldDeserializeEmptyGList(Int32 version) in /gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs:line 480
```

and

```
Failed Gremlin.Net.UnitTest.Structure.IO.GraphBinary.GraphBinaryTests.TestPBetween [6 ms]
gremlin-dotnet-integration-tests    |   Error Message:
gremlin-dotnet-integration-tests    |    Microsoft.CSharp.RuntimeBinder.RuntimeBinderException : The type 'object' must be a non-nullable value type in order to use it as parameter 'T' in the generic type or method 'Xunit.Assert.Equal<T>(T[], T[])'
gremlin-dotnet-integration-tests    |   Stack Trace:
gremlin-dotnet-integration-tests    |      at CallSite.Target(Closure , CallSite , Type , Object , Object )
gremlin-dotnet-integration-tests    |    at System.Dynamic.UpdateDelegates.UpdateAndExecuteVoid3[T0,T1,T2](CallSite site, T0 arg0, T1 arg1, T2 arg2)
gremlin-dotnet-integration-tests    |    at Gremlin.Net.UnitTest.Structure.IO.GraphBinary.GraphBinaryTests.TestPBetween() in /gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphBinary/GraphBinaryTests.cs:line 809
```
@FlorianHockmann FlorianHockmann force-pushed the dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 branch from 5a35850 to 4613832 Compare November 15, 2023 12:53
@FlorianHockmann FlorianHockmann merged commit afd7066 into 3.5-dev Nov 15, 2023
@FlorianHockmann FlorianHockmann deleted the dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 branch November 15, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants