Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet#2324
Merged
FlorianHockmann merged 1 commit into3.5-devfrom Nov 15, 2023
Merged
Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet#2324FlorianHockmann merged 1 commit into3.5-devfrom
FlorianHockmann merged 1 commit into3.5-devfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.5-dev #2324 +/- ##
=============================================
+ Coverage 69.93% 69.94% +0.01%
- Complexity 0 9031 +9031
=============================================
Files 24 866 +842
Lines 3449 41068 +37619
Branches 0 5476 +5476
=============================================
+ Hits 2412 28727 +26315
- Misses 860 10442 +9582
- Partials 177 1899 +1722 ☔ View full report in Codecov by Sentry. |
d1392be to
1b4d1ce
Compare
1b4d1ce to
5a35850
Compare
Bumps [xunit](https://github.com/xunit/xunit) from 2.5.3 to 2.6.1. - [Commits](xunit/xunit@2.5.3...2.6.1) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-minor ... Had to fix two tests due to a type issue related to `dynamic`: ``` Failed Gremlin.Net.UnitTest.Structure.IO.GraphSON.GraphSONReaderTests.ShouldDeserializeEmptyGList(version: 3) [10 ms] gremlin-dotnet-integration-tests | Error Message: gremlin-dotnet-integration-tests | Microsoft.CSharp.RuntimeBinder.RuntimeBinderException : The type 'object' must be a non-nullable value type in order to use it as parameter 'T' in the generic type or method 'Xunit.Assert.Equal<T>(T[], T[])' gremlin-dotnet-integration-tests | Stack Trace: gremlin-dotnet-integration-tests | at CallSite.Target(Closure , CallSite , Type , Object[] , Object ) gremlin-dotnet-integration-tests | at System.Dynamic.UpdateDelegates.UpdateAndExecuteVoid3[T0,T1,T2](CallSite site, T0 arg0, T1 arg1, T2 arg2) gremlin-dotnet-integration-tests | at Gremlin.Net.UnitTest.Structure.IO.GraphSON.GraphSONReaderTests.ShouldDeserializeEmptyGList(Int32 version) in /gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs:line 480 ``` and ``` Failed Gremlin.Net.UnitTest.Structure.IO.GraphBinary.GraphBinaryTests.TestPBetween [6 ms] gremlin-dotnet-integration-tests | Error Message: gremlin-dotnet-integration-tests | Microsoft.CSharp.RuntimeBinder.RuntimeBinderException : The type 'object' must be a non-nullable value type in order to use it as parameter 'T' in the generic type or method 'Xunit.Assert.Equal<T>(T[], T[])' gremlin-dotnet-integration-tests | Stack Trace: gremlin-dotnet-integration-tests | at CallSite.Target(Closure , CallSite , Type , Object , Object ) gremlin-dotnet-integration-tests | at System.Dynamic.UpdateDelegates.UpdateAndExecuteVoid3[T0,T1,T2](CallSite site, T0 arg0, T1 arg1, T2 arg2) gremlin-dotnet-integration-tests | at Gremlin.Net.UnitTest.Structure.IO.GraphBinary.GraphBinaryTests.TestPBetween() in /gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphBinary/GraphBinaryTests.cs:line 809 ```
5a35850 to
4613832
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps xunit from 2.5.3 to 2.6.1.
Commits
9f1684fv2.6.15d9ef4bRemove unnecessary XUNIT_VALUETASK definition0266bacLatest assertionsfb3c3cfRemove all ValueTask support from assertions801790cReconcile AcceptanceTestAssembly and friends with v3f244cc8More shared assertion tests that shouldn't return ValueTask262dd72Shared assertion tests cannot return ValueTask36bbf77Bump up to v2.6.1-pre6a07b95v2.6.05a7297e#2806: Performance improvements in Assert.Equal (v2)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)