Add requestIds to server HTTP error response.#2365
Merged
kenhuuu merged 1 commit intoapache:3.6-devfrom Dec 15, 2023
Merged
Conversation
vkagamlyk
reviewed
Nov 24, 2023
| if (msg instanceof FullHttpMessage){ | ||
| final FullHttpMessage request = (FullHttpMessage) msg; | ||
| final boolean keepAlive = HttpUtil.isKeepAlive(request); | ||
| final RequestMessage requestMessage = HttpHandlerUtil.getRequestMessageFromHttpRequest((FullHttpRequest) request); |
Contributor
There was a problem hiding this comment.
better to put inside try/catch
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 3.6-dev #2365 +/- ##
=============================================
+ Coverage 71.23% 75.15% +3.92%
- Complexity 0 12311 +12311
=============================================
Files 25 1057 +1032
Lines 3772 63466 +59694
Branches 0 6936 +6936
=============================================
+ Hits 2687 47701 +45014
- Misses 898 13192 +12294
- Partials 187 2573 +2386 ☔ View full report in Codecov by Sentry. |
Contributor
|
VOTE +1 |
kenhuuu
force-pushed
the
ken/http-error-fix-3.6
branch
from
c9e0523 to
2c1267f
Compare
Contributor
|
VOTE +1 |
HTTP errors are returned as JSON without requestId. The requestId is required in order to form a ResponseMessage that can be properly deserialized by the Java/Python drivers.
kenhuuu
force-pushed
the
ken/http-error-fix-3.6
branch
from
2c1267f to
b4e7988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP errors are returned as JSON without requestId. The requestId is required in order to form a ResponseMessage that can be properly deserialized by the Java driver.
Not release blocking.