Re-enable certain tests and add fixes.#2621
Merged
kenhuuu merged 3 commits intomaster-httpfrom Jun 4, 2024
Merged
Conversation
Starting in 4.0, gremlin-driver only supports GraphBinary.
Updated to match old behavior where the incoming size of the data is checked so that it doesn't exceed the maxContentLength setting.
Contributor
Author
|
This PR also removes tests that involve session-based script tests as Sessions are being removed, although a recent post was made to clarify this so wait until consensus is reached there |
Contributor
|
VOTE +1 |
Contributor
|
Thanks @kenhuuu, I looked through the changes in the parts of the codebase I'm most familiar with, and it looks like good progress. |
kenhuuu
added a commit
that referenced
this pull request
Jul 6, 2024
* Remove GraphSON feature/process tests. Starting in 4.0, gremlin-driver only supports GraphBinary. * Fix max content length handling to gremlin-driver. Updated to match old behavior where the incoming size of the data is checked so that it doesn't exceed the maxContentLength setting. * Fix and re-enable tests for server and Java driver.
xiazcy
pushed a commit
that referenced
this pull request
Aug 28, 2024
* Remove GraphSON feature/process tests. Starting in 4.0, gremlin-driver only supports GraphBinary. * Fix max content length handling to gremlin-driver. Updated to match old behavior where the incoming size of the data is checked so that it doesn't exceed the maxContentLength setting. * Fix and re-enable tests for server and Java driver.
kenhuuu
added a commit
that referenced
this pull request
Nov 2, 2024
* Remove GraphSON feature/process tests. Starting in 4.0, gremlin-driver only supports GraphBinary. * Fix max content length handling to gremlin-driver. Updated to match old behavior where the incoming size of the data is checked so that it doesn't exceed the maxContentLength setting. * Fix and re-enable tests for server and Java driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables and fixes certain tests that were disabled earlier because the driver and server didn't work together yet. There are still several tests that need to be re-enabled after this (some still aren't working).