Java driver and gremlin server maxContentLength changes for http#2749
Merged
xiazcy merged 1 commit intoapache:master-httpfrom Sep 5, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-http #2749 +/- ##
==============================================
Coverage ? 77.59%
Complexity ? 13420
==============================================
Files ? 1021
Lines ? 58664
Branches ? 6642
==============================================
Hits ? 45523
Misses ? 10910
Partials ? 2231 ☔ View full report in Codecov by Sentry. |
Cole-Greer
reviewed
Aug 28, 2024
.../main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinResponseStreamDecoder.java
Show resolved
Hide resolved
Contributor
|
Thanks @andreachild, LGTM |
andreachild
force-pushed
the
AN-2175_maxResponseContentLength
branch
from
ec147d0 to
e11d764
Compare
andreachild
force-pushed
the
AN-2175_maxResponseContentLength
branch
4 times, most recently
from
4e20a0b to
ba5c437
Compare
vkagamlyk
reviewed
Aug 30, 2024
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java
Outdated
Show resolved
Hide resolved
kenhuuu
reviewed
Aug 30, 2024
| |connectionPool.keyStorePassword |The password of the `keyStore` if it is password-protected. |_none_ | ||
| |connectionPool.keyStoreType |`JKS` (Java 8 default) or `PKCS12` (Java 9+ default)|_none_ | ||
| |connectionPool.maxContentLength |The maximum length in bytes that a message can be sent to the server. This number can be no greater than the setting of the same name in the server configuration. |65536 | ||
| |connectionPool.maxResponseContentLength |The maximum length in bytes that a message can be received from the server. |`Integer.MAX_VALUE` |
Contributor
There was a problem hiding this comment.
Might be nice to just write out 2147483647 instead of Integer.MAX_VALUE. Saves people a step from having to look it up.
Contributor
Author
There was a problem hiding this comment.
Changed to 2147483647
kenhuuu
reviewed
Aug 30, 2024
| } | ||
|
|
||
| @Test | ||
| public void shouldSucceedIfResponseSizeLargerThanMaxResponseContentLength() throws SerializationException { |
Contributor
There was a problem hiding this comment.
The name of this test is bit misleading. shouldSucceed when the assert is that an exception occurs.
Contributor
Author
There was a problem hiding this comment.
Changed to 'shouldThrow'
Contributor
|
VOTE +1 |
…hanged int to long to allow for higher max value, increased default value to Integer.MAX_VALUE as the size check is now done against the total response size instead of previous web socket frame size, and changed zero to be acceptable value which disables the response size check. Gremlin server - renamed maxContentLength to maxRequestContentLength and updated documentation for clarity.
andreachild
force-pushed
the
AN-2175_maxResponseContentLength
branch
from
5950610 to
bff9c62
Compare
Contributor
|
VOTE+1 |
kenhuuu
pushed a commit
that referenced
this pull request
Nov 2, 2024
…hanged int to long to allow for higher max value, increased default value to Integer.MAX_VALUE as the size check is now done against the total response size instead of previous web socket frame size, and changed zero to be acceptable value which disables the response size check. Gremlin server - renamed maxContentLength to maxRequestContentLength and updated documentation for clarity. (#2749)
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
…hanged int to long to allow for higher max value, increased default value to Integer.MAX_VALUE as the size check is now done against the total response size instead of previous web socket frame size, and changed zero to be acceptable value which disables the response size check. Gremlin server - renamed maxContentLength to maxRequestContentLength and updated documentation for clarity. (#2749)
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
…hanged int to long to allow for higher max value, increased default value to Integer.MAX_VALUE as the size check is now done against the total response size instead of previous web socket frame size, and changed zero to be acceptable value which disables the response size check. Gremlin server - renamed maxContentLength to maxRequestContentLength and updated documentation for clarity. (#2749)
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
…hanged int to long to allow for higher max value, increased default value to Integer.MAX_VALUE as the size check is now done against the total response size instead of previous web socket frame size, and changed zero to be acceptable value which disables the response size check. Gremlin server - renamed maxContentLength to maxRequestContentLength and updated documentation for clarity. (#2749)
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
…hanged int to long to allow for higher max value, increased default value to Integer.MAX_VALUE as the size check is now done against the total response size instead of previous web socket frame size, and changed zero to be acceptable value which disables the response size check. Gremlin server - renamed maxContentLength to maxRequestContentLength and updated documentation for clarity. (#2749)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java driver:
Gremlin server:
Feature tests were executed for java driver and pass (other GLV feature tests currently do not work for master-http branch). Manual testing of the changes were done using local gremlin-console with remote connection configured to local gremlin server.