Use .on and .off for unexpected-response listener #2969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unexpected-responselistener needs to use.onand.offbecause thewspackage'saddEventListeneronly accepts certain event typesRef: https://github.com/websockets/ws/blob/8.16.0/lib/event-target.js#L202-L241
Additionally PR #2936 had slightly different logic for the body chunk return, so I have updated that here too.