TINKERPOP-3150 Prevent sample step from having multiple by modulators…

[EchoNullify]

TARGET 3.8-dev

https://issues.apache.org/jira/browse/TINKERPOP-3150

Prevent multiple by operators from being used for sample step by throwing IllegalStateException if modulateBy is called more than once.

[Cole-Greer]

Reminder: Update PR target to 3.8-dev

[Cole-Greer]

Looks like something in ByModulatorOptimizationStrategyTest is failing. It appears something in that test is using sample().by().by() and needs to be corrected or removed. That's probably an issue with the outdated test and not any issue with your change itself.

VOTE +1 pending test fix.

[xiazcy]

VOTE +1

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (3.8-dev@866613a). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...rocess/traversal/step/filter/SampleGlobalStep.java	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             3.8-dev    #3114   +/-   ##
==========================================
  Coverage           ?   76.46%           
  Complexity         ?    13799           
==========================================
  Files              ?     1109           
  Lines              ?    69656           
  Branches           ?     7549           
==========================================
  Hits               ?    53265           
  Misses             ?    13620           
  Partials           ?     2771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.