Replace Bytecode with GremlinLang in .NET driver#3309
Merged
xiazcy merged 3 commits intodotnet-httpfrom Mar 10, 2026
Merged
Conversation
kenhuuu
reviewed
Mar 2, 2026
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversalSource.cs
Outdated
Show resolved
Hide resolved
kenhuuu
reviewed
Mar 2, 2026
kenhuuu
reviewed
Mar 2, 2026
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary/Types/TraversalSerializer.cs
Show resolved
Hide resolved
kenhuuu
reviewed
Mar 2, 2026
...in.Net.IntegrationTest/Process/Traversal/GremlinLangGeneration/GremlinLangGenerationTests.cs
Show resolved
Hide resolved
kenhuuu
reviewed
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Nit: the naming of each unit test in this file is not in line with the rest of this repo. Tests generally named with a "should...", not really a big problem but it makes it difficult to understand what exactly each test is trying to test.
Contributor
Author
There was a problem hiding this comment.
I'm current leaning towards leaving the test name consistent across GLVs. We could revisit and change the names later.
Cole-Greer
reviewed
Mar 3, 2026
gremlin-dotnet/test/Gremlin.Net.UnitTest/Process/Traversal/GremlinLangTests.cs
Show resolved
Hide resolved
Cole-Greer
reviewed
Mar 3, 2026
Contributor
Author
|
VOTE +1 |
1 similar comment
Contributor
|
VOTE +1 |
xiazcy
added a commit
that referenced
this pull request
Mar 11, 2026
xiazcy
added a commit
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces Bytecode with GremlinLang in the .NET Gremlin driver, aligning gremlin-dotnet with the 4.0 format already implemented in Java, Python, and Go.
3 new files were added, GremlinLang.cs, GValue.cs, and GremlinLangTests.cs. All files with Bytecode reference were replaced with GremlinLang. Bytecode specific files as well as all Groovy translator files were deleted.
Note this PR is opened against a feature branch for the 4.0 .NET driver, which will be merged into master after all components are completed. As well, current test are unit tests only, additional changes may be needed once HTTP protocol and serialization are properly implemented with Gherkin tests enabled.