[TINKERPOP-3236] Expand grammar argument types for coin and pagerank …#3331
Merged
Cole-Greer merged 2 commits into3.7-devfrom Mar 23, 2026
Merged
[TINKERPOP-3236] Expand grammar argument types for coin and pagerank …#3331Cole-Greer merged 2 commits into3.7-devfrom
Cole-Greer merged 2 commits into3.7-devfrom
Conversation
…steps to numericArgument
xiazcy
reviewed
Mar 17, 2026
...in-core/src/test/java/org/apache/tinkerpop/gremlin/language/grammar/ArgumentVisitorTest.java
Show resolved
Hide resolved
Contributor
|
I was initially hesistant to this, but I think the argument that most languages will automatically convert a number literal into a floating point has convinced me that this is probably the right thing to do. VOTE +1 |
Contributor
|
VOTE +1 given the reasoning and added feature test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3236
Expanding the grammar to allow any numeric arguments in
coin()andpagerank()to better match groovy and other language variants. This is primarily motivated by the TinkerPop 4 JS work, however I would argue this change is justified in all TP versions. I consider this suitable for 3.7-dev as it is loosening an existing constraint, not imposing any new ones.VOTE +1