Backport gremlin-js node 22+ compatibility changes from 3.8 to 3.7#3333
Merged
Backport gremlin-js node 22+ compatibility changes from 3.8 to 3.7#3333
Conversation
Contributor
|
VOTE +1 |
Contributor
|
I would consider this breaking for any users who previously relied on globalWebSockets being used with the default client configuration, which will now be swapped to Regardless, I think this is outweighed by the need to support Node 22 and 24 now that Node 20 is passing end of life in a month. VOTE +1 |
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original change to 3.8, back-porting to 3.7 due to node 20 reaching EOF in Apr. This should be non-breaking for the upcoming 3.7.6 release.
VOTE +1